Everyday wear: boxers. Sometimes ripped and revealing. Occasionally (weekends) white briefs.
And when I want to be sexy, or can get away with being seen wearing one, like for doctor's appointments, skin exams, massages, etc, jockstraps
Jockstraps are hardly ever worn for sports anymore. Athletes nowadays tend to go with compression shorts instead, although jocks who need cups may tend to wear them with a cup.
My mom got me my 1st "athletic supporter" as she called it when I was in high school, some 40+ years ago. It was that off white / beige "vintage" type. From the moment I saw it and put it on, it looked and felt like sexy male lingerie, more so than anything athletic. I went 35 years being shy about being seen in it, I would have rather been caught nude. Then I did a 180 degree turn, and now have many jocks, and many pics on yourjockstraps and allkink. You might say I have a fetish for them